-
Notifications
You must be signed in to change notification settings - Fork 645
Add Android Support #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android Support #147
Conversation
@chirag04 @Palisand @Jose4gg @tizzyapunkt Would you like to test this feature? 😀 |
@Swordsman-Inaction Unfortunately, I am unable to test this. Since I am using Expo, |
ce7f8aa
to
a7de5e1
Compare
@Palisand OK... I don't use |
@Swordsman-Inaction With these changes, space gets added below the view holding the input, so it works just fine if I scroll manually. By the way, are there any plans for making the view scroll to the text input cursor (for multiline inputs) rather than the bottom of the input? I've tried to accomplish this myself, but found that RN doesn't expose the cursor's location. |
I used this as a drop in replacement for the APSL version for my project and it worked perfect. Thanks Swordsman-Inaction! When will this request get merged? |
@Palisand The first issue, |
@Swordsman-Inaction I've only compared APSL's master version and your forked repo's android-support branch and with the latter, space does get added below the view when I focus on the input. I wasn't treating it as an issue as I thought this was intentional (and it's a welcome change). From what I've learned, the second one appears possible only on the native level. |
@Palisand I see, you are saying |
@Swordsman-Inaction I never included nor tested those props, only |
@Palisand Yes, that's right. 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to merge! Have you tested it under Android?
@Swordsman-Inaction ping me when all the PRs are merged and I'll perform a release. Thanks for your work! |
I've upgraded to react-native 0.46.+, changed my AndroidManifest file, and set |
@nicotroia I don't believe there was a new release of this library, yet even though this is merged in. |
I'm waiting for @Swordsman-Inaction confirmation to release 0.3.0. |
@Swordsman-Inaction any updates? |
@hose314 Should be released soon, already confirmed with @alvaromb before. 😄 |
I can confirm it will be released tomorrow morning CEST. Thanks! |
Hey!
We'll have Android Support now! You guys can check the README about this.
This feature is not perfect, since there is no
keyboardWillShow
on Android, we cannot be notified before the keyboard is showed. So sometimes we could get wrong position of focused TextInput because it's already in the process of showing keyboard which makeskeyboardSpace
not accurate occasionally.Feel free to review the code and test on your app!
Fix #2