Hook to android keyboard events #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-aware-scroll-view into hook-to-android-keyboard-events
|
Thank you @nlively! I'm going to close mine in favor on this one |
timLoewel
reviewed
Feb 19, 2017
| @@ -107,6 +113,9 @@ const KeyboardAwareMixin = { | |||
| * @param extraHeight: takes an extra height in consideration. | |||
| */ | |||
| scrollToFocusedInput: function (reactNode: Object, extraHeight: number = this.props.extraHeight) { | |||
| // Android already does this | |||
| if(isAndroid()) return; | |||
There was a problem hiding this comment.
Android does not use this.props.extraHeight.
|
Closed in favor of #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to PR #29 by @grsabreu.
This update resolves the merge conflicts between that PR and master.