Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

Various design improvements #1023

Merged
merged 18 commits into from
Jun 9, 2023
Merged

Various design improvements #1023

merged 18 commits into from
Jun 9, 2023

Conversation

Smooth-E
Copy link
Contributor

@Smooth-E Smooth-E commented Jun 4, 2023

A set of changes to make AndroidIDE look better!

  • Enable Dynamic coloring inside of the Main Activity
  • Use android:fitsSystemWindows or similar flags in MainActivity to illuminate inconsistent system-bar coloring
  • Use android:fitsSystemWindows or similar flags in Preferences, especially to fix the status-bar remaining background color followed by a brightly colored toolbar when a user scrolls the list of preferences
  • Use android:fitsSystemWindows or similar flags in the editor activity to remove white system-bars when you open drawers
    Adding edge-to-edge for the editor activity deserves its own Pull Request

I will do slight styling adjustments to some of the files I touch, if you don't mind (unused import removal, readability improvement and the general look of the code).

@itsaky itsaky changed the title Vrious design improvements Various design improvements Jun 5, 2023
@Smooth-E
Copy link
Contributor Author

Smooth-E commented Jun 6, 2023

Should I add setPaddingBottom(...) / addPAddingBottom(...) and similar methods for every side here as well, considering that if we are aiming for immersive edge-to-edge experiences, then we will have to set paddings manually a lot?

Smooth-E added 9 commits June 6, 2023 20:00
…ges for MainActivity. This allows to ship more specific layout changes and is a ground work to support split screen mode.

* Bug introduced: templates are not shown in the TemplateListFragment after full activity rebuild
…s alive. This ensures that the last item in template list is always aligned to the start.
…ove InsetUtils outside of the LimitlessIDEActivity.
…, fix a one-line if statement to follow the general codestyle
The reasoning behind this is that after `view.setPadding(left, top, right, bottom)` is executed, `view.getPaddingBottom()` (or for any other side) still returns the old value of padding before the view is measured again. Therefore the implementation of PaddingUtils.kt produces an unwanted and unexpected behaviour.
@Smooth-E
Copy link
Contributor Author

Smooth-E commented Jun 8, 2023

Fine, it seems like everything is ready for a merge now. I've decided to not improve the editor activity for now, as it will require a lot of rewiring after activity rebuilds.

🖼️ Here is a set of screenshots to present everything added. Expand to view!



System UI Demo Mode apparently stopped working for several last shots 🫠

I've enabled a very vibrant Material You profile just to prove that dynamic colors are working everywhere. Also thougth of making screenshots with an emulator so display cutout would be visible, but the emulator decided to not use dynamic coloring for some palette entries for some reason.

@Smooth-E Smooth-E marked this pull request as ready for review June 8, 2023 10:03
@Smooth-E
Copy link
Contributor Author

Smooth-E commented Jun 8, 2023

Should I add setPaddingBottom(...) / addPAddingBottom(...) and similar methods for every side here as well, considering that if we are aiming for immersive edge-to-edge experiences, then we will have to set paddings manually a lot?

I ended up removing PaddingUtils all together, so no need to decide anymore.

@itsaky itsaky merged commit 1ee2f34 into AndroidIDEOfficial:dev Jun 9, 2023
@itsaky
Copy link
Member

itsaky commented Jun 9, 2023

Thank you for your contribution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants