This repository was archived by the owner on Oct 18, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Dynamic coloring in MainActivity
…hroughout the IDE
Should I add |
…ges for MainActivity. This allows to ship more specific layout changes and is a ground work to support split screen mode. * Bug introduced: templates are not shown in the TemplateListFragment after full activity rebuild
…ctivity rebuild or a configuration change
…s alive. This ensures that the last item in template list is always aligned to the start.
…ove InsetUtils outside of the LimitlessIDEActivity.
…, fix a one-line if statement to follow the general codestyle
The reasoning behind this is that after `view.setPadding(left, top, right, bottom)` is executed, `view.getPaddingBottom()` (or for any other side) still returns the old value of padding before the view is measured again. Therefore the implementation of PaddingUtils.kt produces an unwanted and unexpected behaviour.
I ended up removing |
… inside the *New project* wizard's footer
itsaky
suggested changes
Jun 8, 2023
app/src/main/java/com/itsaky/androidide/app/LimitlessIDEActivity.kt
Outdated
Show resolved
Hide resolved
common/src/main/java/com/itsaky/androidide/ui/BottomInsetHeightDistributor.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/itsaky/androidide/activities/MainActivity.kt
Outdated
Show resolved
Hide resolved
itsaky
approved these changes
Jun 9, 2023
Thank you for your contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of changes to make AndroidIDE look better!
android:fitsSystemWindows
or similar flags in MainActivity to illuminate inconsistent system-bar coloringandroid:fitsSystemWindows
or similar flags in Preferences, especially to fix the status-bar remaining background color followed by a brightly colored toolbar when a user scrolls the list of preferencesUseandroid:fitsSystemWindows
or similar flags in the editor activity to remove white system-bars when you open drawersAdding edge-to-edge for the editor activity deserves its own Pull Request
I will do slight styling adjustments to some of the files I touch, if you don't mind (unused import removal, readability improvement and the general look of the code).