feat(edge-to-edge): Implement edge-to-edge for PreferencesActivity, m…

…ove InsetUtils outside of the LimitlessIDEActivity.

app/src/main/AndroidManifest.xml

@@ -61,9 +61,7 @@
       android:configChanges="orientation|screenSize"
       android:launchMode="singleTop"
       android:windowSoftInputMode="adjustResize" />
-    <activity
-      android:name=".activities.PreferencesActivity"
-      android:configChanges="orientation|screenSize" />
+    <activity android:name=".activities.PreferencesActivity" />
     <activity
       android:name=".activities.AboutActivity"
       android:configChanges="orientation|screenSize" />

app/src/main/java/com/itsaky/androidide/activities/PreferencesActivity.java

@@ -17,8 +17,10 @@
 
 package com.itsaky.androidide.activities;
 
+import android.graphics.Rect;
 import android.os.Bundle;
 import android.view.View;
+import android.widget.LinearLayout;
 
 import androidx.annotation.NonNull;
 import androidx.fragment.app.Fragment;
@@ -38,6 +40,10 @@ public class PreferencesActivity extends LimitlessIDEActivity {
   private ActivityPreferencesBinding binding;
   private IDEPreferencesFragment rootFragment;
 
+  public PreferencesActivity() {
+    super(true);
+  }
+
   @Override
   protected void onCreate(Bundle savedInstanceState) {
     super.onCreate(savedInstanceState);
@@ -47,7 +53,7 @@ protected void onCreate(Bundle savedInstanceState) {
     getSupportActionBar().setDisplayHomeAsUpEnabled(true);
 
     binding.toolbar.setNavigationOnClickListener(v -> onBackPressed());
-  
+
     if (savedInstanceState != null) {
       return;
     }
@@ -59,13 +65,41 @@ protected void onCreate(Bundle savedInstanceState) {
 
     final var args = new Bundle();
     args.putParcelableArrayList(
-        IDEPreferencesFragment.EXTRA_CHILDREN, new ArrayList<>(prefs.getChildren()));
+            IDEPreferencesFragment.EXTRA_CHILDREN,
+            new ArrayList<>(prefs.getChildren())
+    );
 
     final var root = getRootFragment();
     root.setArguments(args);
     loadFragment(root);
   }
-
+
+  @Override
+  public void onInsetsUpdated(@NonNull Rect insets) {
+    super.onInsetsUpdated(insets);
+
+    View toolbar = binding.toolbar;
+    toolbar.setPadding(
+            toolbar.getPaddingLeft() + insets.left,
+            toolbar.getPaddingTop(),
+            toolbar.getPaddingRight() + insets.right,
+            toolbar.getPaddingBottom()
+    );
+
+    View fragmentContainer = binding.fragmentContainerParent;
+    fragmentContainer.setPadding(
+            fragmentContainer.getPaddingLeft() + insets.left,
+            fragmentContainer.getPaddingTop(),
+            fragmentContainer.getPaddingRight() + insets.right,
+            fragmentContainer.getPaddingBottom()
+    );
+
+    binding.paddingDistributor.setLayoutParams(new LinearLayout.LayoutParams(
+            LinearLayout.LayoutParams.MATCH_PARENT,
+            insets.bottom
+    ));
+  }
+
   @Override
   @NonNull
   protected View bindLayout() {
@@ -77,8 +111,8 @@ private IDEPreferencesFragment getRootFragment() {
     return rootFragment == null ? rootFragment = new IDEPreferencesFragment() : rootFragment;
   }
 
-  private void loadFragment(Fragment frag) {
-    super.loadFragment(frag, binding.fragmentContainer.getId());
+  private void loadFragment(Fragment fragment) {
+    super.loadFragment(fragment, binding.fragmentContainer.getId());
   }
 
   @Override

app/src/main/java/com/itsaky/androidide/app/LimitlessIDEActivity.kt

@@ -17,25 +17,28 @@
 
 package com.itsaky.androidide.app
 
+import android.content.res.Configuration
 import android.graphics.Color
-import android.graphics.Insets
 import android.graphics.Rect
 import android.os.Build
 import android.os.Bundle
 import android.os.PersistableBundle
-import android.view.View
-import android.view.WindowInsets
+import android.util.TypedValue
 import android.view.WindowManager.LayoutParams.LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
 import androidx.core.view.WindowCompat
 import androidx.core.view.doOnAttach
+import com.itsaky.androidide.utils.NavigationBar
+import com.itsaky.androidide.utils.getInsets
 
 /**
  * Same as IDEActivity but DecorFitsSystemWindows is set to false
- * Useful for creating immersive experiences
+ * Useful for creating immersive edge-to-edge experiences
  *
  * @author Smooth E
  */
-abstract class LimitlessIDEActivity : IDEActivity() {
+abstract class LimitlessIDEActivity(
+  private val highlightNavigationBar: Boolean = false
+) : IDEActivity() {
 
   override fun onCreate(savedInstanceState: Bundle?) {
     super.onCreate(savedInstanceState)
@@ -51,8 +54,8 @@ abstract class LimitlessIDEActivity : IDEActivity() {
 
   private fun makeLimitless() {
     WindowCompat.setDecorFitsSystemWindows(window, false)
-    window.statusBarColor = Color.TRANSPARENT
-    window.navigationBarColor = Color.TRANSPARENT
+
+    paintNavigationBar()
 
     // This removes a black strip on the side where the camera cutout is in landscape mode
     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
@@ -61,42 +64,39 @@ abstract class LimitlessIDEActivity : IDEActivity() {
   }
 
   private fun installOnDecorViewAttachedListener() {
-    window.decorView.doOnAttach { decorView -> updateInsets(decorView) }
+    window.decorView.doOnAttach { decorView -> onInsetsUpdated(getInsets(decorView)) }
   }
 
-  private fun updateInsets(decorView: View)
-  {
-    val insets: Rect
-    val rootWindowInsets = decorView.rootWindowInsets
-
-    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
-
-      val receivedInsets: Insets = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
-        val typeMask = WindowInsets.Type.systemBars() or WindowInsets.Type.displayCutout()
-        rootWindowInsets.getInsetsIgnoringVisibility(typeMask)
-      } else {
-        decorView.rootWindowInsets.stableInsets
-      }
-
-      insets = Rect(
-        receivedInsets.left,
-        receivedInsets.top,
-        receivedInsets.right,
-        receivedInsets.bottom
-      )
-    } else {
-      insets = Rect(
-        rootWindowInsets.stableInsetLeft,
-        rootWindowInsets.stableInsetTop,
-        rootWindowInsets.stableInsetRight,
-        rootWindowInsets.stableInsetBottom
-      )
+  /** Called whenever insets are updated */
+  open fun onInsetsUpdated(insets: Rect) { }
+
+  private fun paintNavigationBar() {
+    window.statusBarColor = Color.TRANSPARENT
+    window.navigationBarColor = Color.TRANSPARENT
+
+    if (!highlightNavigationBar) {
+      return
     }
 
-    onInsetsUpdated(insets)
-  }
+    val refrainHighlighting =
+      NavigationBar.getInteractionMode(this) == NavigationBar.MODE_GESTURES ||
+      resources.configuration.orientation == Configuration.ORIENTATION_LANDSCAPE
 
-  /** Called when insets are updated */
-  open fun onInsetsUpdated(insets: Rect) { }
+    if (refrainHighlighting) {
+      return
+    }
+
+    var id = com.google.android.material.R.attr.colorSurface
+    var typedValue = TypedValue()
+    theme.resolveAttribute(id, typedValue, true)
+    window.navigationBarColor = typedValue.data
+
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
+      id = com.google.android.material.R.attr.colorOutlineVariant
+      typedValue = TypedValue()
+      theme.resolveAttribute(id, typedValue, true)
+      window.navigationBarDividerColor = typedValue.data
+    }
+  }
 
 }

app/src/main/res/layout/activity_preferences.xml

@@ -23,11 +23,38 @@
 
   </com.google.android.material.appbar.AppBarLayout>
 
-
-  <FrameLayout
-    android:id="@+id/fragmentContainer"
+  <androidx.core.widget.NestedScrollView
+    android:id="@+id/fragment_container_parent"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    app:layout_behavior="com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior" />
+    app:layout_behavior="com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior">
+
+    <LinearLayout
+      android:layout_width="match_parent"
+      android:layout_height="wrap_content"
+      android:orientation="vertical">
+
+      <FrameLayout
+        android:id="@+id/fragmentContainer"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"/>
+
+      <!--
+        TODO: Implement a custom view which is meant to be placed at the end of
+          a ScrollView and will have dimensions
+          of match_parent - [ navigation bar height ] (width / height)
+      -->
+      <!--
+        This view fills up the space on the bottom of the scroll for the content
+        above it to not be blocked by the navigation bar
+      -->
+      <FrameLayout
+        android:id="@+id/padding_distributor"
+        android:layout_width="match_parent"
+        android:layout_height="0dp" />
+
+    </LinearLayout>
+
+  </androidx.core.widget.NestedScrollView>
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>

common/src/main/java/com/itsaky/androidide/utils/InsetUtils.kt

@@ -0,0 +1,64 @@
+/*
+ *  This file is part of AndroidIDE.
+ *
+ *  AndroidIDE is free software: you can redistribute it and/or modify
+ *  it under the terms of the GNU General Public License as published by
+ *  the Free Software Foundation, either version 3 of the License, or
+ *  (at your option) any later version.
+ *
+ *  AndroidIDE is distributed in the hope that it will be useful,
+ *  but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *  GNU General Public License for more details.
+ *
+ *  You should have received a copy of the GNU General Public License
+ *   along with AndroidIDE.  If not, see <https://www.gnu.org/licenses/>.
+ */
+
+package com.itsaky.androidide.utils
+
+import android.graphics.Insets
+import android.graphics.Rect
+import android.os.Build
+import android.view.View
+import android.view.WindowInsets
+
+/**
+ * Acquires screen insets
+ *
+ * @param view Any View that is currently attached to a Window
+ *
+ * @return [Rect] containing acquired insets
+ *
+ * @author Smooth E
+ */
+fun getInsets(view: View): Rect {
+  val insets: Rect
+  val rootWindowInsets = view.rootWindowInsets
+
+  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+
+    val receivedInsets: Insets = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
+      val typeMask = WindowInsets.Type.systemBars() or WindowInsets.Type.displayCutout()
+      rootWindowInsets.getInsetsIgnoringVisibility(typeMask)
+    } else {
+      view.rootWindowInsets.stableInsets
+    }
+
+    insets = Rect(
+      receivedInsets.left,
+      receivedInsets.top,
+      receivedInsets.right,
+      receivedInsets.bottom
+    )
+  } else {
+    insets = Rect(
+      rootWindowInsets.stableInsetLeft,
+      rootWindowInsets.stableInsetTop,
+      rootWindowInsets.stableInsetRight,
+      rootWindowInsets.stableInsetBottom
+    )
+  }
+
+  return insets
+}

resources/src/main/res/values/styles.xml

@@ -73,13 +73,6 @@
   </style>
 
   <style name="Theme.AndroidIDE" parent="Theme.AndroidIDE.Styled">
-    <!--
-    <item name="android:windowDrawsSystemBarBackgrounds">true</item>
-    <item name="android:windowTranslucentNavigation">true</item>
-    <item name="android:windowTranslucentStatus">true</item>
-    <item name="android:enforceNavigationBarContrast" tools:targetApi="29">false</item>
-    <item name="android:enforceStatusBarContrast" tools:targetApi="29">false</item>
-    -->
     <item name="android:statusBarColor">@android:color/transparent</item>
     <item name="android:navigationBarColor">@android:color/transparent</item>
     <item name="android:windowLightStatusBar">true</item>