Skip to content

feat(gsoc): convert timing diagram to vue component #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

Arnabdaz
Copy link
Member

@Arnabdaz Arnabdaz commented Aug 8, 2023

Fixes Timing Diagram to Vue component

Describe the changes you have made in this PR -

  • fix functionality of timing diagram in the Vue simualtor
  • remove & reduce DOM manipulation
  • remove jQuery
  • add typescript and i18n support
  • separate component for buttons to reduce code duplication

Screenshots of the changes (If any) -

image

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@commit-lint
Copy link

commit-lint bot commented Aug 8, 2023

Features

  • gsoc: initial working convertion of timing diagram to vue component (c83170e)
  • gsoc: remove dom manipulation of when plot width is changed with vue refs (e3dd4b2)
  • gsoc: use panelHeader for the header of timing diagram (1d357c7)
  • gsoc: add vue methods to input of cycleunits (9755c63)
  • gsoc: add i18n to timingDiagram component (1657853)

Contributors

Arnabdaz

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 1657853
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/64d29d1f1de89900089ef64a
😎 Deploy Preview https://deploy-preview-183--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@devartstar devartstar merged commit 77d78bb into CircuitVerse:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants