Skip to content

feat(gsoc): convert timing diagram to vue component #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2023
Merged

feat(gsoc): convert timing diagram to vue component #183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c83170e
feat(gsoc): initial working convertion of timing diagram to vue compo…
Arnabdaz Aug 6, 2023
e3dd4b2
feat(gsoc): remove dom manipulation of when plot width is changed wit…
Arnabdaz Aug 8, 2023
1d357c7
feat(gsoc): use panelHeader for the header of timing diagram
Arnabdaz Aug 8, 2023
9755c63
feat(gsoc): add vue methods to input of cycleunits
Arnabdaz Aug 8, 2023
1657853
feat(gsoc): add i18n to timingDiagram component
Arnabdaz Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(gsoc): use panelHeader for the header of timing diagram 
Signed-off-by: Arnabdaz <[email protected]>
  • Loading branch information
@Arnabdaz
Arnabdaz committed Aug 8, 2023
commit 1d357c76cccaf2fce8c510f0ccd1f1930dc108d1
9 changes: 9 additions & 0 deletions src/components/Panels/Shared/PanelHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,12 @@ const props = defineProps({
headerTitle: { type: String, default: 'Panel Header' },
})
</script>

<style scoped>
.fa-external-link-square-alt {
cursor: pointer;
}
.fa-minus-square {
cursor: pointer;
}
</style>
11 changes: 3 additions & 8 deletions src/components/Panels/TimingDiagramPanel/TimingDiagramPanel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
<template>
<div class="timing-diagram-panel draggable-panel">
<!-- Timing Diagram Panel -->
<div class="panel-header">
Timing Diagram
<span class="fas fa-minus-square minimize panel-button"></span>
<span
class="fas fa-external-link-square-alt maximize panel-button-icon"
></span>
</div>
<PanelHeader title="Timing Diagram" />
<div class="panel-body">
<div class="timing-diagram-toolbar noSelect">
<TimingDiagramButtons
Expand Down Expand Up @@ -48,8 +42,9 @@ import plotArea from '#/simulator/src/plotArea'
import { buttonActions } from '#/simulator/src/plotArea'
import TimingDiagramButtons from './TimingDiagramButtons.vue'
import buttonsJSON from '#/assets/constants/Panels/TimingDiagramPanel/buttons.json'
import PanelHeader from '../Shared/PanelHeader.vue'

const buttons = ref(buttonsJSON)
const buttons = ref<object>(buttonsJSON)
const plotRef = ref<HTMLElement | null>(null)

function handleButtonClick(button: string) {
Expand Down