Fixes checking for github bots in contributors #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Br3nda
force-pushed
the
contributors-bots
branch
3 times, most recently
from
e8c57fc to
e7d9ca8
Compare
Br3nda
force-pushed
the
contributors-bots
branch
from
e7d9ca8 to
c8e5cec
Compare
Br3nda
requested review from
a team,
CloCkWeRX,
cesy,
jenkr55,
maco,
milesgould,
pmackay and
pozorvlak
milesgould
suggested changes
Feb 8, 2019
milesgould
left a comment
milesgould
left a comment
There was a problem hiding this comment.
This fixes our immediate problem, but there are some things I don't like about it:
- verifying that you've put the correct number of backslashes takes some thought;
- we'll have the same problem if a contributor has any other regex metacharacter in their username.
One possibility is to shell out to fgrep rather than grep, or to pass grep the -F (match fixed strings) option. Or we could read the file into Ruby and search it ourselves, which would IMHO be a bit cleaner (and yes, I wrote the original code, and I'm not proud).
Member
Author
|
Good idea. I've changed it to read in Ruby. |
Br3nda
force-pushed
the
contributors-bots
branch
3 times, most recently
from
6480dbe to
70f5fa9
Compare
Br3nda
force-pushed
the
contributors-bots
branch
from
70f5fa9 to
bffbd94
Compare
milesgould
approved these changes
Feb 11, 2019
pozorvlak
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all the travis-ci fails for dependabot PRs.