Skip to content

Fixes checking for github bots in contributors #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 11, 2019
Merged

Fixes checking for github bots in contributors #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c8e5cec
Fixes checking for github bots in contributors
Br3nda Feb 7, 2019
bffbd94
Read the file contents in ruby
Br3nda Feb 8, 2019
cde61a1
Use Regex to search for author
Br3nda Feb 8, 2019
61548e0
Merge branch 'dev' into contributors-bots
Br3nda Feb 8, 2019
6902f30
Merge branch 'dev' into contributors-bots
Br3nda Feb 9, 2019
68d9b9c
Merge branch 'dev' into contributors-bots
Br3nda Feb 9, 2019
29da3f7
Merge branch 'dev' into contributors-bots
Br3nda Feb 9, 2019
f83b8e7
Merge branch 'dev' into contributors-bots
pozorvlak Feb 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,4 @@ submit the change with your pull request.

### Security and Dependency Updates
- DeppBot / [deppbot](https://github.com/deppbot)
- dependabot[bot] / [dependabot-bot] / [dependabot] (https://github.com/dependabot-bot)
- dependabot / [dependabot](https://github.com/dependabot)
- dependabot[bot] (https://github.com/dependabot-bot)
7 changes: 6 additions & 1 deletion script/check_contributors_md.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#!/usr/bin/env ruby
require "English"

puts "Checking to see if you're in CONTRIBUTORS.md..."

if ENV['TRAVIS']
if ENV['TRAVIS_PULL_REQUEST']
require 'httparty'
Expand All @@ -27,7 +29,10 @@
end
end

unless system('grep', '-i', author, 'CONTRIBUTORS.md')
# Escape chars in name, and make case insensitive
author_to_search_for = Regexp.new(Regexp.escape(author), Regexp::IGNORECASE)

unless File.read('CONTRIBUTORS.md').match?(author_to_search_for)
abort %(
Thanks for your contribution, #{author}!
Please add your name and GitHub handle to the file CONTRIBUTORS.md,
Expand Down