WIP: Try use method deletion instead of custom sysimage #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
force-pushed
the
kc/method_deletion
branch
from
f2275cb to
155645e
Compare
KristofferC
force-pushed
the
kc/method_deletion
branch
from
155645e to
e240ea4
Compare
jishnub
reviewed
Apr 25, 2025
|
This seems to work, it's a bit more messy but it is probably worth doing considering that generating a sysimage takes so long. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1312 +/- ##
==========================================
+ Coverage 92.17% 93.73% +1.55%
==========================================
Files 34 34
Lines 15642 15682 +40
==========================================
+ Hits 14418 14699 +281
+ Misses 1224 983 -241 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Let's try it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.