Skip to content

WIP: Try use method deletion instead of custom sysimage #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 25, 2025
Merged

WIP: Try use method deletion instead of custom sysimage #1312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e240ea4
WIP: Try use method deletion instead of custom sysimage
KristofferC Apr 25, 2025
4e0201d
fix name check
KristofferC Apr 25, 2025
6f66af2
add back code coverage
KristofferC Apr 25, 2025
ba5b005
integration check that we are actually running the custom LA code
KristofferC Apr 25, 2025
037ff2f
Revert "integration check that we are actually running the custom LA …
KristofferC Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions .buildkite/runtests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ steps:
version: "nightly"
arch: "i686"
command: |
julia --color=yes --project=.ci -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=.ci .ci/create_sysimage_and_run_tests.jl
julia --color=yes --code-coverage=@ .ci/run_tests.jl
agents:
queue: "julia"
os: "linux"
Expand All @@ -40,8 +39,7 @@ steps:
- JuliaCI/julia#v1:
version: "nightly"
command: |
julia --color=yes --project=.ci --code-coverage=@ -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=.ci --code-coverage=@ .ci/create_sysimage_and_run_tests.jl
julia --color=yes --code-coverage=@ .ci/run_tests.jl
agents:
queue: "julia"
os: "linux"
Expand All @@ -55,8 +53,7 @@ steps:
- JuliaCI/julia-coverage#v1:
codecov: true
command: |
julia --color=yes --project=.ci --code-coverage=@ -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=.ci --code-coverage=@ .ci/create_sysimage_and_run_tests.jl
julia --color=yes --code-coverage=@ .ci/run_tests.jl
agents:
queue: "julia"
os: "macos"
Expand All @@ -69,8 +66,7 @@ steps:
- JuliaCI/julia-coverage#v1:
codecov: true
command: |
julia --color=yes --project=.ci --code-coverage=@ -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=.ci --code-coverage=@ .ci/create_sysimage_and_run_tests.jl
julia --color=yes --code-coverage=@ .ci/run_tests.jl
agents:
queue: "julia"
os: "windows"
Expand Down
222 changes: 0 additions & 222 deletions .ci/Manifest.toml
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions .ci/Project.toml
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions .ci/create_sysimage.jl
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions .ci/create_sysimage_and_run_docs.jl
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions .ci/create_sysimage_and_run_tests.jl
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions .ci/run_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
if haskey(ENV, "BUILDKITE")
ncores = Sys.CPU_THREADS
else
ncores = ceil(Int, Sys.CPU_THREADS / 2)
end

proj = abspath(joinpath(@__DIR__, ".."))
cmd = """Base.runtests(["LinearAlgebra"]; propagate_project=true, ncores=$ncores)"""
withenv("JULIA_NUM_THREADS" => 1) do
run(`$(Base.julia_cmd()) --project=$proj --compiled-modules=existing -e $cmd`)
end
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@ jobs:
version: 'nightly'
- name: Generate docs
run: |
julia --color=yes --project=.ci -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=docs -e 'using Pkg; Pkg.instantiate()'
julia --color=yes --project=.ci .ci/create_sysimage_and_run_docs.jl
julia --color=yes --project=docs --compiled-modules=existing docs/make.jl
env:
DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 2 additions & 0 deletions docs/make.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
include("../test/prune_old_LA.jl")

using LinearAlgebra
using Documenter: DocMeta, makedocs, deploydocs, HTML

Expand Down
2 changes: 2 additions & 0 deletions test/abstractq.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

module TestAbstractQ

isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl")

using Test
using LinearAlgebra
using LinearAlgebra: AbstractQ, AdjointQ
Expand Down
2 changes: 2 additions & 0 deletions test/addmul.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

module TestAddmul

isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl")

using Base: rtoldefault
using Test
using LinearAlgebra
Expand Down
2 changes: 2 additions & 0 deletions test/adjtrans.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

module TestAdjointTranspose

isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl")

using Test, LinearAlgebra

const BASE_TEST_PATH = joinpath(Sys.BINDIR, "..", "share", "julia", "test")
Expand Down
2 changes: 2 additions & 0 deletions test/bidiag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

module TestBidiagonal

isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl")

using Test, LinearAlgebra, Random
using LinearAlgebra: BlasReal, BlasFloat

Expand Down
2 changes: 2 additions & 0 deletions test/bitarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl")

using LinearAlgebra, Test, Random

tc(r1::NTuple{N,Any}, r2::NTuple{N,Any}) where {N} = all(x->tc(x...), [zip(r1,r2)...])
Expand Down
2 changes: 2 additions & 0 deletions test/blas.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

module TestBLAS

isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl")

using Test, LinearAlgebra, Random
using LinearAlgebra: BlasReal, BlasComplex
using Libdl: dlsym, dlopen
Expand Down
2 changes: 2 additions & 0 deletions test/bunchkaufman.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

module TestBunchKaufman

isdefined(Main, :pruned_old_LA) || @eval Main include("prune_old_LA.jl")

using Test, LinearAlgebra, Random
using LinearAlgebra: BlasComplex, BlasFloat, BlasReal, QRPivoted
using Base: getproperty
Expand Down
Loading