Skip to content

Fix empty Tridiagonal broadcast #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Apr 30, 2025

Fixes

julia> T = Tridiagonal(1:0, 1:0, 1:0)
0×0 Tridiagonal{Int64, UnitRange{Int64}}

julia> T .+ T
ERROR: ArgumentError: invalid GenericMemory size: the number of elements is either negative or too large for system address width

After this,

julia> T .+ T
0×0 Tridiagonal{Int64, Vector{Int64}}

The changes are minor, but the largish diff is because of adding a loop to the tests, and additional indentation as a consequence.

@jishnub jishnub added arrays [a, r, r, a, y, s] backport 1.11 Change should be backported to the 1.11 release backport 1.12 Change should be backported to release-1.12 backport 1.10 Change should be backported to the 1.10 release labels Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (41db513) to head (7c66b6b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1324      +/-   ##
==========================================
+ Coverage   93.73%   93.74%   +0.01%     
==========================================
  Files          34       34              
  Lines       15750    15750              
==========================================
+ Hits        14763    14765       +2     
+ Misses        987      985       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit dccd6f8 into master Apr 30, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/structured_alloc_tri branch April 30, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s] backport 1.10 Change should be backported to the 1.10 release backport 1.11 Change should be backported to the 1.11 release backport 1.12 Change should be backported to release-1.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants