Skip to content

Bugfix for ContainerRegistry repository Install-PSResource with varying digit version #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 27, 2025

Conversation

anamnavi
Copy link
Member

@anamnavi anamnavi commented Feb 18, 2025

Installing from a container registry repository should work even when the version the resource was published with is not the same as the normalized version, (i.e published version is 1.0, but normalized version is 1.0.0). The previous code was using the normalized version to query for the registry tag (version) and it wasn't an exact match. The exact tag is retrieved from the manifest and stored in PSResourceInfo.Version so use that for Install-PSResource.

For prerelease versions, when creating the normalized version string to write to the PSGetModuleInfo.xml file it was looking for versions with 3 or 4 digits, not accounting for 2 digits.

PR Summary

PR Context

Resolve #1623

PR Checklist

@alerickson
Copy link
Member

Can you add a note in the summary on the prerelease bug and fix for it as well?

@anamnavi anamnavi merged commit 6915968 into master Feb 27, 2025
12 checks passed
@anamnavi anamnavi deleted the bugfix-containerregistry-2digitinstall branch March 6, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing a resource from ACR fails
3 participants