Skip to content

Bugfix for ContainerRegistry repository Install-PSResource with varying digit version #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 27, 2025
Merged

Bugfix for ContainerRegistry repository Install-PSResource with varying digit version #1796

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5840fa6
fix install for a package from MAR that may have different version th…
anamnavi Feb 18, 2025
177af24
add find and install tests for 2 digit pkg
anamnavi Feb 18, 2025
35c9f94
add -TrustRepository to install tests
anamnavi Feb 18, 2025
dd17571
account for prerelease version when using manifest version
anamnavi Feb 18, 2025
336d910
add test for preview install
anamnavi Feb 18, 2025
f51a8b8
fix error in test logic
anamnavi Feb 18, 2025
8e0dd47
Merge branch 'master' of https://github.com/PowerShell/PSResourceGet …
anamnavi Feb 24, 2025
a253650
Merge branch 'master' of https://github.com/PowerShell/PSResourceGet …
anamnavi Feb 25, 2025
fa0880b
account for 2 digit version being concatenated with prerelease when c…
anamnavi Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add -TrustRepository to install tests
  • Loading branch information
@anamnavi
anamnavi committed Feb 18, 2025
commit 35c9f946f4564d1a5330bfe5182f351aaaed2622
8 changes: 4 additions & 4 deletions test/InstallPSResourceTests/InstallPSResourceContainerRegistryServer.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,31 +78,31 @@ Describe 'Test Install-PSResource for ACR scenarios' -tags 'CI' {

It "Install resource when version contains different number of digits than the normalized version- 1 digit specified" {
# the resource has version "1.0", but querying with any equivalent version should work
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1" -Repository $ACRRepoName
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1" -Repository $ACRRepoName -TrustRepository
$res = Get-InstalledPSResource -Name $testModuleWith2DigitVersion
$res | Should -Not -BeNullOrEmpty
$res.Version | Should -Be "1.0"
}

It "Install resource when version contains different number of digits than the normalized version- 2 digits specified" {
# the resource has version "1.0", but querying with any equivalent version should work
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1.0" -Repository $ACRRepoName
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1.0" -Repository $ACRRepoName -TrustRepository
$res = Get-InstalledPSResource -Name $testModuleWith2DigitVersion
$res | Should -Not -BeNullOrEmpty
$res.Version | Should -Be "1.0"
}

It "Install resource when version contains different number of digits than the normalized version- 3 digits specified" {
# the resource has version "1.0", but querying with any equivalent version should work
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1.0.0" -Repository $ACRRepoName
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1.0.0" -Repository $ACRRepoName -TrustRepository
$res = Get-InstalledPSResource -Name $testModuleWith2DigitVersion
$res | Should -Not -BeNullOrEmpty
$res.Version | Should -Be "1.0"
}

It "Install resource when version contains different number of digits than the normalized version- 4 digits specified" {
# the resource has version "1.0", but querying with any equivalent version should work
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1.0.0.0" -Repository $ACRRepoName
Install-PSResource -Name $testModuleWith2DigitVersion -Version "1.0.0.0" -Repository $ACRRepoName -TrustRepository
$res = Get-InstalledPSResource -Name $testModuleWith2DigitVersion
$res | Should -Not -BeNullOrEmpty
$res.Version | Should -Be "1.0"
Expand Down