Allows rubybench to be run on shopify heroku #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryliu55
changed the title
jerryliu55
force-pushed
the
run-on-heroku
branch
2 times, most recently
from
2d3db6d to
4c2fc9e
Compare
jerryliu55
force-pushed
the
run-on-heroku
branch
2 times, most recently
from
8425df8 to
c2131b3
Compare
Install phantomJS 2.1.1 manually to fix travis
* remove special log paths (they weren't working on heroku) * change UNICORN_PORT -> PORT since heroku uses PORT * uncomment production database config since we're not using 'pups' to uncomment it * update redis url to use REDISCLOUD_URL
* remove redis from procfile since rediscloud doesn't need it * add a sidekiq worker with 10 concurrencies
* add API_URL to POST to shopify-rubybench.herokuapp.com * use shopifydockerhub/rubybench_ruby_trunk docker image * add ORGANIZATION env variable to all remote jobs since we support multiple organizations per repo (ex. github/ruby, ruby/ruby)
ex. github/ruby and ruby/ruby
jerryliu55
force-pushed
the
run-on-heroku
branch
from
c2131b3 to
8e40f73
Compare
|
Hi @jerryliu55, is shopify running ruby-bench-web internally as well? 😃 To be honest, I've been struggling to find time to improve ruby-bench-web on a consistent basis so I'll love to see how we can collaborate on this. If you don't mind, could you start a topic on http://community.rubybench.org and we can discuss about ways we might be able to centralize the efforts on RubyBench? |
|
@tgxworld Yep, we're running ruby-bench internally! We're mainly looking for the minimum viable solution to aggregate benchmarks on custom performance-patched builds of ruby. Past the JSON API, we're not planning on making many more changes. That being said, if there's a small project you'd like help on, we'd love to set aside some time for that 😄 |
added 5 commits
February 24, 2017 15:40
For now, we are using Shopify/ruby-mirror as a way to trigger benchmark runs for ruby/ruby
Since we sometimes change the `organization` variable
* only run benchmarks on branches: master, trunk, benchmark<something> * use github secret token instead of user/pass via ApiController
Changes to remote_server_job and github_event_handler (secret token) broke some tests
jerryliu55
force-pushed
the
run-on-heroku
branch
from
e3af112 to
145c637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes: