Skip to content

Allows rubybench to be run on shopify heroku #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests that were broken by multi-org per repo changes
  • Loading branch information
Jerry Liu committed Feb 24, 2017
commit 10f11ffe271e03f10f9bc9dc0c8e0d4a284471ca
20 changes: 15 additions & 5 deletions test/acceptance/view_benchmark_graphs_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,18 @@ class ViewBenchmarkGraphsTest < AcceptanceTest

test "User should be able to see long running benchmark graph even without
memory benchmarks".squish do

benchmark_run = create(:commit_benchmark_run)
benchmark_type = benchmark_run.benchmark_type
benchmark_type = create(:benchmark_type)
benchmark_result_type = create(:benchmark_result_type)
repo = benchmark_type.repo
org = repo.organization
commit = create(:commit, repo: repo)

benchmark_run = create(:commit_benchmark_run,
benchmark_result_type: benchmark_result_type,
benchmark_type: benchmark_type,
initiator: commit
)

benchmark_run_category_humanize = benchmark_type.category.humanize

visit repo_path(organization_name: org.name, repo_name: repo.name)
Expand All @@ -96,9 +103,12 @@ class ViewBenchmarkGraphsTest < AcceptanceTest
benchmark_result_type = create(:benchmark_result_type)

30.times do
commit = create(:commit, repo: repo)
create(
:commit_benchmark_run, benchmark_type: benchmark_type,
benchmark_result_type: benchmark_result_type
:commit_benchmark_run,
benchmark_type: benchmark_type,
benchmark_result_type: benchmark_result_type,
initiator: commit
)
end

Expand Down