Optimisation - Removed a lot of garbage allocation #1804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed a few IEnumerable instances to IReadOnlyList. This avoids some unnecessary GC allocs that cast the Lists to IEnumerables. - Moved cdf allocation outside of the loop to avoid unnecessary GC allocation. - Changed GeneratorImpl to use plain float and int arrays instead of Array during generation. This avoids SetValue performing boxing on the arrays, which eliminates an awful lot of GC allocs.
vincentpierre
suggested changes
Mar 13, 2019
vincentpierre
approved these changes
Mar 19, 2019
LeSphax
pushed a commit
to LeSphax/ml-agents-1
that referenced
this pull request
May 3, 2020
…s#1804) * Garbage collection optimisations: - Changed a few IEnumerable instances to IReadOnlyList. This avoids some unnecessary GC allocs that cast the Lists to IEnumerables. - Moved cdf allocation outside of the loop to avoid unnecessary GC allocation. - Changed GeneratorImpl to use plain float and int arrays instead of Array during generation. This avoids SetValue performing boxing on the arrays, which eliminates an awful lot of GC allocs. * Convert InferenceBrain to use IReadOnlyList to avoid garbage creation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this change, I've made various changes that keep the functionality the same whilst creating a lot less garbage. This results in faster training and less GC Collect spikes during playback.
I hope you find them useful.
Regards
Graham