-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Updated package.json to use the correct casing for the 'main' entrypoint #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In the rollup script 'angularFire2.umd.js' is used, where in the package.json 'angularfire2.umd.js' was used, causing for loading problems on linux based systems (Ubuntu in this case)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@meDavid The casing is wrong on our side actually. We'd rather change the casing in the rollup config. https://github.com/angular/angularfire2/blob/master/rollup.publish.config.js#L5 Would you like to change those two files and then I'll merge the PR? |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed and modified the github accountname for the CLA |
@davideast |
@maxmumford The CLA check no longer worked for me. I updated the CLA details to contain my github username, but it didn't update the cla label. |
In the rollup script 'angularFire2.umd.js' is used, where in the package.json 'angularfire2.umd.js' was used, causing for loading problems on linux based systems (Ubuntu in this case)
https://github.com/angular/angularfire2/blob/master/rollup.publish.config.js#L5