Skip to content

Updated package.json to use the correct casing for the 'main' entrypoint #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

meDavid
Copy link

@meDavid meDavid commented Sep 20, 2016

In the rollup script 'angularFire2.umd.js' is used, where in the package.json 'angularfire2.umd.js' was used, causing for loading problems on linux based systems (Ubuntu in this case)

https://github.com/angular/angularfire2/blob/master/rollup.publish.config.js#L5

In the rollup script 'angularFire2.umd.js'  is used, where in the package.json 'angularfire2.umd.js' was used, causing for loading problems on linux based systems (Ubuntu in this case)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@davideast
Copy link
Collaborator

davideast commented Sep 20, 2016

@meDavid The casing is wrong on our side actually. We'd rather change the casing in the rollup config.

https://github.com/angular/angularfire2/blob/master/rollup.publish.config.js#L5
https://github.com/angular/angularfire2/blob/master/rollup.test.config.js#L7

Would you like to change those two files and then I'll merge the PR?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@meDavid
Copy link
Author

meDavid commented Sep 21, 2016

I signed and modified the github accountname for the CLA

@meDavid
Copy link
Author

meDavid commented Sep 21, 2016

@davideast
I didn't modify https://github.com/angular/angularfire2/blob/master/rollup.test.config.js#L7 as it was the module name and not the file name. The rollup test config doesn't affect this issue as it uses a totally different filename.

@maxmumford
Copy link
Contributor

This has been merged now under #599. Thanks @meDavid for finding and providing the fix.

@meDavid
Copy link
Author

meDavid commented Oct 11, 2016

@maxmumford The CLA check no longer worked for me. I updated the CLA details to contain my github username, but it didn't update the cla label.

@meDavid meDavid closed this Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants