Updated package.json to use the correct casing for the 'main' entrypoint #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the rollup script 'angularFire2.umd.js' is used, where in the package.json 'angularfire2.umd.js' was used, causing for loading problems on linux based systems (Ubuntu in this case)
|
@davideast sorry to duplicate PR #534 but I need this fix for my project and it looks like @meDavid isn't responding to the CLA signing request. |
|
@maxmumford Thanks, Max! |
|
Great, thanks @davideast ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install,npm run build, andnpm testrun successfully? yesDescription
This PR fixes issue #543. The actual code change was written by @meDavid from PR #534 but he hasn't yet signed the CLA and my project needs this PR to be merged for deployment.
Code sample
In the rollup script 'angularFire2.umd.js' is used, where in the package.json 'angularfire2.umd.js' was used, causing for loading problems on linux based systems (Ubuntu in this case)