Skip to content

fix: the git commit hash in the docker is empty string #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 7, 2021

Conversation

nic-chen
Copy link
Member

@nic-chen nic-chen commented Feb 7, 2021

Please answer these questions before submitting a pull request


Bugfix

  • Description
    In the docker build, the compressed package of github is directly downloaded, which does not contain git information, that causes the git commit hash to be empty string

  • How to fix?
    use git repo source code to build docker image.

@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #1446 (5b65877) into master (8796fa1) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1446      +/-   ##
==========================================
+ Coverage   67.61%   67.71%   +0.09%     
==========================================
  Files          48       48              
  Lines        3042     3042              
==========================================
+ Hits         2057     2060       +3     
+ Misses        741      738       -3     
  Partials      244      244              
Impacted Files Coverage Δ
api/internal/core/storage/etcd.go 46.36% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8796fa1...5b65877. Read the comment docs.

@nic-chen nic-chen requested a review from starsz February 7, 2021 08:17
@juzhiyuan juzhiyuan requested a review from imjoey February 7, 2021 08:55
Copy link
Member

@imjoey imjoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks.

@imjoey imjoey merged commit c5f5739 into apache:master Feb 7, 2021
@imjoey
Copy link
Member

imjoey commented Feb 7, 2021

Hi. @juzhiyuan @starsz , this PR needs to be backported to v2.4 branch for release 2.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: the commit_hash in the demo is empty string
5 participants