-
Notifications
You must be signed in to change notification settings - Fork 558
fix: the git commit hash in the docker is empty string #1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1446 +/- ##
==========================================
+ Coverage 67.61% 67.71% +0.09%
==========================================
Files 48 48
Lines 3042 3042
==========================================
+ Hits 2057 2060 +3
+ Misses 741 738 -3
Partials 244 244
Continue to review full report at Codecov.
|
…sion number of the master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks.
Hi. @juzhiyuan @starsz , this PR needs to be backported to v2.4 branch for release 2.4. |
Co-authored-by: nic-chen <[email protected]>
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
close Bug: the commit_hash in the demo is empty string #1438
Bugfix
Description
In the docker build, the compressed package of github is directly downloaded, which does not contain git information, that causes the git commit hash to be empty string
How to fix?
use git repo source code to build docker image.