Skip to content

backport: fix: the git commit hash in the docker is empty string (#1446) #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

imjoey
Copy link
Member

@imjoey imjoey commented Feb 7, 2021

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

Backport patches

  • Why need to backport?
    It's included in 2.4 release with the plan.

In the docker build, the compressed package of github is directly downloaded, which does not contain git information, that causes the git commit hash to be empty string. Use git repo source code to build docker image.

@imjoey imjoey added the backport label Feb 7, 2021
@imjoey
Copy link
Member Author

imjoey commented Feb 7, 2021

ping @juzhiyuan @nic-chen @liuxiran for reviewing this backport PR. Thanks.

@liuxiran liuxiran merged commit 45ac0e2 into apache:v2.4 Feb 7, 2021
@imjoey imjoey deleted the backport_1446_to_v2_4 branch February 7, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants