Flash on cordova.apache.org?

[NiklasMerz]

I just noticed Firefox is bringing a flash warning. Is Adobe Flash really necessary to use cordova.apache.org

(German for "This website uses Adobe Flash, Only alllow on trusted sites)

[timbru31]

Interesting. I couldn't trigger a warning regarding Flash on https://cordova.apache.org/blog/ - could you possibly investigate further which caused this?

[breautek]

I'm also unable to reproduce this. Perhaps its a browser addon?

[timbru31]

Just a random idea: could the Twitter feed/widget perhaps (still) use Flash?

[breautek]

Just a random idea: could the Twitter feed/widget perhaps (still) use Flash?

I was thinking about this too... Perhaps if the tweet contains a video?

[NiklasMerz]

I just tested another browser (Firefox Linux, previous one was Firefox Windows) and there is a similar flash warning. Will investigate...

[NiklasMerz]

It should be ZeroClipBoard which is loading a .swf file. That should be the Flash script file

Should be fairly easy to remove -> https://github.com/apache/cordova-docs/search?q=ZeroClipboard&unscoped_q=ZeroClipboard

Should I go ahead and create a PR?

[breautek]

Weird, I get a ZeripClipboard.js file, but I don't see a ZeroClipboard.swf file being requested (on chrome)

I see the same on firefox.

I'm running on linux, wonder if it's OS-dependent. Now I think about it, I don't even think I have flash installed... so that could be why.

[NiklasMerz]

I just disabled the "Shockwave flash plugin" in Firefox on Linux and now the icon in the URL bar is gone. I cannot see the swf file too.

There is no point in keeping this library right? Flash is gone from modern modern browsers and EOL by Adobe in year as far as I know.

[breautek]

Not sure where this library is actually used, but I think generally speaking it can probably be refactored out and use a pure js solution based on https://caniuse.com/#feat=clipboard

[brody4hire]

I would also like to understand some historical context to understand why and what may be broken before removing things like this.

Starting from this line: https://github.com/apache/cordova-docs/blob/master/www/static/plugins/app.js#L29

I took a look through the history and discovered that this ZeroClipboard thing was introduced in PR #395.

Unfortunately PR #395 copied a bunch of files from some branch that I do not see any record of so far, at least. Bad for attribution of contributions and bad for understanding historical context of things.

[NiklasMerz]

I just did some searches and it looks like it is just used for the "copy" buttons next to the CLI commands on this page: https://cordova.apache.org/#getstarted

The plugin looks for buttons with the class btn-copy and those are the only ones.

Moving to a JS only solution might be the best option to get that working again. Looks like the page is a React/Preact app. I don't have much expertise with React.

There seems to be a JS fallback without flash! I am working on removing the flash part and get only the JS fallback working.

cordova-docs/www/static/plugins/plugin.jsx

Line 22 in 44678ac

copyTextWithoutFlash: function() {

[NiklasMerz]

I think I may got removing ZeroClipBoard right. It works locally for me in Firefox and Chromium on Linux.

[dblotsky]

This was 100% for the “copy” buttons. I don’t recall now why JS-only wasn’t enough. Please validate on at least Ubuntu, macOS, and Windows on some modern set of browsers.

[NiklasMerz]

If this was done in 2015, those were different times :-). Maybe Internet Explorer? I dont't know much about the clipboard API, but I think it's time to get rid of flash now since most browser won't support it anyway.

I will test this on Windows and macOS at work soon. My test right now was done on Linux Mint (Ubuntu based).