Remove ZeroClipBoard to remove flash from docs #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblotsky
reviewed
Dec 11, 2019
brody4hire
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Approved on my part.
Seems to basically use the existing fallback for no working flash, which has evidently already been working on Linux and other platforms with no flash-enabled browser.
Easiest to check with diff with no space changes: https://github.com/apache/cordova-docs/pull/1032/files?utf8=%E2%9C%93&diff=unified&w=1
P.S. See this guide for reference: https://github.blog/2018-05-01-ignore-white-space-in-code-review/
NiklasMerz
commented
Dec 12, 2019
This was referenced Dec 12, 2019
NiklasMerz
added a commit
that referenced
this pull request
Jan 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ZeroClipBoardLibrary and moves the clipboard buttons to the native JS API.
Closes #1031