Skip to content

Remove ZeroClipBoard to remove flash from docs #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

NiklasMerz
Copy link
Member

This PR removes the ZeroClipBoardLibrary and moves the clipboard buttons to the native JS API.

Closes #1031

Copy link
Contributor

@dblotsky dblotsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was 100% for the “copy” buttons. I don’t recall now why JS-only wasn’t enough at the time. Please validate on at least Ubuntu, macOS, and Windows on some modern set of browsers.

Copy link

@brody4hire brody4hire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on my part.

Seems to basically use the existing fallback for no working flash, which has evidently already been working on Linux and other platforms with no flash-enabled browser.

Easiest to check with diff with no space changes: https://github.com/apache/cordova-docs/pull/1032/files?utf8=%E2%9C%93&diff=unified&w=1

P.S. See this guide for reference: https://github.blog/2018-05-01-ignore-white-space-in-code-review/

Copy link
Member Author

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a quick test on Windows 10 and macOS Mojave with these browsers Firefox, Chrome, Internet Explorer, Safari. Looking good for me.

@brody4hire brody4hire merged commit 68cb4d2 into apache:master Dec 12, 2019
NiklasMerz added a commit that referenced this pull request Jan 16, 2020
"setClipboardText" was renamed to "copyText" in #1032. This fixes two method calls for a new issue #1047.
NiklasMerz added a commit that referenced this pull request Jan 18, 2020
"setClipboardText" was renamed to "copyText" in #1032. This fixes two method calls for a new issue #1047.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flash on cordova.apache.org?
3 participants