Skip to content

Update repositories.txt #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update repositories.txt #1084

wants to merge 1 commit into from

Conversation

akkoyun
Copy link
Contributor

@akkoyun akkoyun commented Feb 20, 2022

No description provided.

@github-actions
Copy link
Contributor

Hi @akkoyun.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions github-actions bot added the topic: modification Change existing list entry label Feb 20, 2022
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/akkoyun/I2C_Functions

ERROR: Submission URL is already in the Library Manager index.

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @akkoyun
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 February 20, 2022 13:33
@akkoyun
Copy link
Contributor Author

akkoyun commented Feb 20, 2022

@ArduinoBot I want to remove the library from list.

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 February 20, 2022 13:35
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/akkoyun/I2C_Functions

ERROR: Submission URL is already in the Library Manager index.

@github-actions
Copy link
Contributor

Hi @akkoyun.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @akkoyun
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 February 20, 2022 13:36
@per1234
Copy link
Contributor

per1234 commented Feb 20, 2022

Hello @akkoyun. I see your pull request moves the https://github.com/akkoyun/I2C_Functions URL from line 4661 to 4678:

https://github.com/arduino/library-registry/pull/1084/files

Was there a reason you wanted to move it?

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Feb 20, 2022
@per1234 per1234 self-assigned this Feb 20, 2022
@per1234
Copy link
Contributor

per1234 commented Feb 20, 2022

Ah, I see now you commented while I was replying:

I want to remove the library from list.

That is fine. Please update the PR to remove the URL from the list rather than moving it from one line to another.

Once that is done, I will proceed with the removal as requested.

@akkoyun
Copy link
Contributor Author

akkoyun commented Feb 20, 2022

Hello @akkoyun. I see your pull request moves the https://github.com/akkoyun/I2C_Functions URL from line 4661 to 4678:

https://github.com/arduino/library-registry/pull/1084/files

Was there a reason you wanted to move it?

My library is shown wrong on Arduino so I want to delete the old submission and add it again.

@per1234
Copy link
Contributor

per1234 commented Feb 20, 2022

My library is shown wrong on Arduino

What do you mean by "wrong" @akkoyun?

Of course, you are always welcome to remove libraries from the list if you want, but I may be able to suggest a more efficient way of fixing that issue than going through a removal and resubmission process.

@akkoyun
Copy link
Contributor Author

akkoyun commented Feb 20, 2022

name and version showed wrong on library manager.

@akkoyun
Copy link
Contributor Author

akkoyun commented Feb 20, 2022

My library is shown wrong on Arduino

What do you mean by "wrong" @akkoyun?

Of course, you are always welcome to remove libraries from the list if you want, but I may be able to suggest a more efficient way of fixing that issue than going through a removal and resubmission process.

what is your advice, my friend?

@per1234 per1234 mentioned this pull request Feb 20, 2022
@per1234
Copy link
Contributor

per1234 commented Feb 20, 2022

Libraries in the Library Manager list are locked to the name they had at the time they were added to the list. At the time the library was added, the name value in the library.properties metadata file was set to "Generic I2C Functions":

https://github.com/akkoyun/I2C_Functions/blob/01.00.00/library.properties#L1

name=Generic I2C Functions

So it was registered under that name:

https://github.com/akkoyun/I2C_Functions.git|Contributed|Generic I2C Functions

I see you have since changed the name value to "I2C_Functions".

The Library Manager indexer rejects any release that uses a name value which does not match the registration data. The dedicated Library Manager indexer logs webpage for your library shows that the tags since the name change have been rejected:

http://downloads.arduino.cc/libraries/logs/github.com/akkoyun/I2C_Functions/

2022/02/20 14:21:55 Checking out tag: 01.01.01
2022/02/20 14:21:55 Release I2C_Functions:1.1.1 has wrong library name, should be Generic I2C Functions
2022/02/20 14:21:55 Checking out tag: 01.02.00
2022/02/20 14:21:55 Release I2C_Functions:1.2.0 has wrong library name, should be Generic I2C Functions

So this is the reason you are not seeing the 1.1.1 and 1.2.0 releases listed in Arduino Library Manager, and why the library is still listed under "Generic I2C Functions".


So I think the easiest thing is for us to just update the registration name data for you. That is more straightforward than doing a removal and then resubmission.

I have initiated the name change on your behalf: #1087

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests and merges the PRs when that is done. If you are subscribed to the linked PR, you'll get a notification at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
The 1.1.1 and 1.2.0 releases will be automatically added to the index once the name change has been made.

Please let me know if you have any questions or concerns.
Regards, Per

@per1234 per1234 closed this Feb 20, 2022
@per1234 per1234 added status: pending backend Depends on backend maintenance operations topic: rename Change registered library name and removed status: waiting for information More information must be provided before work can proceed labels Feb 20, 2022
@per1234 per1234 removed topic: modification Change existing list entry status: pending backend Depends on backend maintenance operations labels Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: rename Change registered library name
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants