Skip to content
This repository was archived by the owner on Feb 12, 2022. It is now read-only.

Conversation

@dabonnie
Copy link
Contributor

@dabonnie dabonnie commented Jul 17, 2020

Removed unnecessary manual addition of importlib dependencies, which are not needed for dashing.

Signed-off-by: Devin Bonnie [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dabonnie dabonnie force-pushed the dabonnie/test-importlib-dependency branch from 7090786 to 61bb58d Compare July 17, 2020 00:03
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files          18       18           
  Lines         885      885           
=======================================
  Hits          793      793           
  Misses         92       92           
Flag Coverage Δ
#ROS_1 89.60% <ø> (ø)
#ROS_2 91.76% <ø> (ø)
#dashing 91.76% <ø> (ø)
#kinetic 89.69% <ø> (ø)
#melodic 91.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ebc2cb...a0399b4. Read the comment docs.

@dabonnie dabonnie force-pushed the dabonnie/test-importlib-dependency branch from 61bb58d to 1a2ba55 Compare July 17, 2020 00:10
@dabonnie dabonnie force-pushed the dabonnie/test-importlib-dependency branch from 1a2ba55 to 92ab7b8 Compare July 17, 2020 00:17
@dabonnie dabonnie changed the title Remove manual install of importlib dependencies Remove manual install of importlib Jul 17, 2020
@dabonnie dabonnie marked this pull request as ready for review July 17, 2020 00:30
@thomas-moulard
Copy link

LGTM - nit: be careful when renaming workflows. The list of workflows actually blocking the PRs is stored as a string, so if you rename a "required" workflow, it won't be required anymore until someone fixes the repo settings.

Copy link

@zmichaels11 zmichaels11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add to the PR description why we're removing this?

@dabonnie
Copy link
Contributor Author

dabonnie commented Jul 17, 2020

LGTM - nit: be careful when renaming workflows. The list of workflows actually blocking the PRs is stored as a string, so if you rename a "required" workflow, it won't be required anymore until someone fixes the repo settings.

Good to know, thanks. That's not configured yet, but will configure after merging.

Can you add to the PR description why we're removing this?

Will do.

@dabonnie dabonnie merged commit f9b4f4a into master Jul 17, 2020
@dabonnie dabonnie deleted the dabonnie/test-importlib-dependency branch July 17, 2020 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants