-
Notifications
You must be signed in to change notification settings - Fork 183
open readme.md
with codecs.open
#474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since the `README.md` contains some unicode characters, it is better to open it with `codecs.open`
Thank you, this has already been fixed in 4325130 |
It has been fixed for |
I missed that this is in the exception handler. Thanks for the fix. |
@yassersouri - can I ask how you found this issue? Did you clone this repository or was it via |
It was though |
@yassersouri - that's interesting, I can't reproduce this error in my environment. Could you please provide the output of the following commands in your environment? What operating system are you using, and are you using the system Python or a local account one?
Here is the output of
|
It was inside a docker. @tahajahangir will provide more info for you. |
In side docker (an image derived from official debian-jessie image), the We set |
Also it was on python 3.5 |
Thanks for that information, that helps a lot. |
@tahajahangir @yassersouri - do you have any of these environment variables exported as well? (docs)
Interestingly enough, |
I've misspelled LC_TYPE, we set the correct The issue is also occurs with |
Thanks again. @tahajahangir - that explains why I did not see the issue. Arch Linux sets just about every environment variable related to character encoding to $ declare -x|fgrep -i utf
declare -x LANG="en_US.UTF-8"
declare -x LC_ADDRESS="en_US.UTF-8"
declare -x LC_COLLATE="en_US.UTF-8"
declare -x LC_CTYPE="en_US.UTF-8"
declare -x LC_IDENTIFICATION="en_US.UTF-8"
declare -x LC_MEASUREMENT="en_US.UTF-8"
declare -x LC_MESSAGES="en_US.UTF-8"
declare -x LC_MONETARY="en_US.UTF-8"
declare -x LC_NAME="en_US.UTF-8"
declare -x LC_NUMERIC="en_US.UTF-8"
declare -x LC_PAPER="en_US.UTF-8"
declare -x LC_TELEPHONE="en_US.UTF-8"
declare -x LC_TIME="en_US.UTF-8" I will modify the release process to ensure these variables are either unset or set to |
We were installing the package on a machine when this happened:
I think this might fix the error.