Skip to content

Use default Python file encoding during test / release process #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2016

Conversation

lukebakken
Copy link
Contributor

@lukebakken lukebakken commented May 19, 2016

Unexport vars related to encoding, ensure files are opened with utf-8 when necessary.

Fixes #476 (CLIENTS-864)
Addresses #474

@lukebakken
Copy link
Contributor Author

@javajolt this was an interesting issue

@lukebakken lukebakken force-pushed the features/lrb/encoding-gh-476 branch from 34ea44a to 5e5c550 Compare May 19, 2016 13:36
@hazen
Copy link

hazen commented May 19, 2016

@lukebakken I should be able to test this by setting my default lang to something crazy like ANSI_X3.4-1968 and everything should work, right?

@lukebakken
Copy link
Contributor Author

That's one way, but if you use the Makefile targets it will ensure any environment vars that set lang will be unset. That way you'll use whatever the default is for your Python interpreter.

@lukebakken
Copy link
Contributor Author

lukebakken commented May 19, 2016

@javajolt - do you have any set in your env? What is the output of these commands?

declare -x | fgrep LC_
echo $LANG

The above would output a lot of variables since Arch Linux sets them all to be UTF-8

@hazen
Copy link

hazen commented May 19, 2016

declare -x LANG="en_US.UTF-8"

@lukebakken
Copy link
Contributor Author

OK so the Makefile will unexport that and Python will use whatever its default is.

@hazen
Copy link

hazen commented May 19, 2016

Seems to work fine

@hazen
Copy link

hazen commented May 19, 2016

👍 5e5c550

@lukebakken lukebakken merged commit a8139a5 into master May 19, 2016
@lukebakken lukebakken deleted the features/lrb/encoding-gh-476 branch May 19, 2016 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants