Expose deferred screen edges setting for ios devices #18729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
yonson2
changed the title
alice-i-cecile
approved these changes
Apr 5, 2025
alice-i-cecile
added
A-Windowing
greeble-dev
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
I don't have much knowledge of windowing or iOS, but I'm clicking approve as I couldn't spot any blocking issues.
I did notice that the Bevy ScreenEdge is more limited than winit's - Bevy's is an enum but winit's is a bitfield. Not sure if that's intentional? I added a suggestion that links the ScreenEdge documentation to winit's - if the limitation is intentional then I guess that comment should also note the limitation.
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This setting is useful for ios apps that make use of the screen edges, letting the app have control of the first edge gesture before relegating to the os.
Testing