Making so animation transition is able to handle multiple active animations! #18954
+176
−178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Sirmadeira
changed the title
alice-i-cecile
added
C-Feature
|
@mweatherley @pcwalton Kindly review, would love this feature on 0.16.1. |
Sirmadeira
changed the title
…e cant be based on graph due to reduplication of clips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective - Finished
In this PR I make it so AnimationTransitions component, actually has a concept called flows! Which will ease up the introduction of StateMachines for Animations
I also believe he shouldnt be limited by the idea of one sole "main" animation specially with the advent of layer through AnimationMasks. As the current implementation does
Solution
-In this case I make it so instead, of having the idea of one sole active animation, transitions actually has the ability of having multiple flows. Each flow having a one-to-one "main" animation. This will work nicely, with @pcwalton additive blends, and masks, and should mantain all the previous features of AnimationTransitions.