Skip to content

Strip unused features from bevy_asset dependencies #18979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2025
Merged

Strip unused features from bevy_asset dependencies #18979

merged 4 commits into from
May 5, 2025

Conversation

bushrat011899
Copy link
Contributor

Objective

Solution

  • Disable default features on all dependencies in bevy_asset and explicitly enable ones that are required.
  • Remove compile_error caused by enabling file_watcher without multi_threaded by including multi_threaded in file_watcher.

Testing

  • CI

Notes

No breaking changes here, just a little cleaning before the more controversial changes for no_std support.

@bushrat011899
Disable default features
5726de3 
Only enable the features in `bevy_asset`'s dependencies that are needed.
@bushrat011899
Remove compile_error when enabling file_watcher without `multi_th…
d43517c 
…readed`

Just enable `multi_threaded` when `file_watcher` is enabled.
@bushrat011899
taplo
3eab2aa
@ickshonpe ickshonpe added A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 29, 2025
@bushrat011899
Copy link
Contributor Author

CI failures unrelated to this PR (new nightly lint and a check-advisory for atomic-polyfill)

@bushrat011899 bushrat011899 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 4, 2025
@mockersf mockersf added this pull request to the merge queue May 5, 2025
Merged via the queue into bevyengine:main with commit ea7e868 May 5, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@andriyDev andriyDev andriyDev approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Code-Quality A section of code that is hard to understand or change D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bushrat011899 @mockersf @andriyDev @ickshonpe