Skip to content

Improve visibility of debug picking node #18990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

benfrankel
Copy link
Contributor

@benfrankel benfrankel commented Apr 30, 2025

Objective

Fixes #18989.

Solution

Add GlobalZIndex(i32::MAX), BackgroundColor(Color::BLACK.with_alpha(0.75)), and some padding.

Testing

Ran cargo run --example debug_picking:

2025-04-30_1745997924_1280x720

Before this PR:

2025-04-29_1745972540_1280x720

@benfrankel
Copy link
Contributor Author

The CI failure doesn't seem to be related to this PR's changes.

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels May 5, 2025
@alice-i-cecile
Copy link
Member

Does this completely fix the linked issue?

@benfrankel
Copy link
Contributor Author

Yep, unless the user puts their UI in GlobalZIndex(i32::MAX) 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Picking Pointing at and selecting objects of all sorts C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug picking is drawn at Z index 0
3 participants