Remove parking_lot
from bevy_asset
and bevy_macro_utils
#18996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
no_std
forbevy_asset
#18978 by removing a dependency that is notno_std
compatibleSolution
parking_lot
frombevy_asset
and switched tobevy_platform::sync
internally.parking_lot
frombevy_macro_utils
and switched tostd::sync
internally. Also added a simple alternative to mappedRwLock
guards while the feature is nightly-only.Testing
Notes
It is possible there is a performance change here, but I believe it will be negligible due to performance improvements in
std
since Bevy adoptedparking_lot
in #210. If there is a performance difference noticed, I believe the more appropriate course of action would be to moveparking_lot
intobevy_platform
as a feature, so that all parts of Bevy could benefit, not justbevy_asset
.