Skip to content

Fix a few subcrate import paths in examples #19002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

rparrett
Copy link
Contributor

Objective

Tripped over the directional_navigation one recently while playing around with that example.

Examples should import items from bevy rather than the sub-crates directly.

Solution

Use paths re-exported by bevy.

Testing

cargo run --example log_diagnostics
cargo run --example directional_navigation
cargo run --example custom_projection

@alice-i-cecile
Copy link
Member

Interesting, we have CI checks for this. I wonder why they didn't trigger here.

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Apr 30, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 30, 2025
@mockersf
Copy link
Member

Interesting, we have CI checks for this. I wonder why they didn't trigger here.

CI is checking for imports, those are direct use

Merged via the queue into bevyengine:main with commit b40845d Apr 30, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants