Skip to content

Extract members of PickingPlugin and PointerInputPlugin into new types #19078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Extract members of PickingPlugin and PointerInputPlugin into new types #19078

wants to merge 6 commits into from

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented May 5, 2025

Objective

PickingPlugin and PointerInputPlugin were kinda weird being both a plugin and a resource.

Solution

Extract the resource functionality of PickingPlugin and PointerInputPlugin into new resources

Testing

mesh_picking and sprite_picking

@alice-i-cecile alice-i-cecile requested a review from NthTensor May 5, 2025 16:58
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Picking Pointing at and selecting objects of all sorts labels May 5, 2025
alice-i-cecile
alice-i-cecile requested changes May 5, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a migration guide and some docs explaining how to configure the plugins, but I really like these changes otherwise.

@alice-i-cecile alice-i-cecile added M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 5, 2025
@hukasu
Copy link
Contributor Author

hukasu commented May 5, 2025

i waited to push the commit with the migration guides for after opening the PR so that i could write the PR number on them

@alice-i-cecile alice-i-cecile removed the S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged label May 5, 2025
alice-i-cecile
alice-i-cecile approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@NthTensor NthTensor Awaiting requested review from NthTensor

Assignees
No one assigned
Labels
A-Picking Pointing at and selecting objects of all sorts C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hukasu @alice-i-cecile