Skip to content

replace async-std with async-io #19113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VitalyAnkh
Copy link
Contributor

Objective

Solution

  • Replace async-std with async-io.

Testing

CI

@VitalyAnkh
Copy link
Contributor Author

VitalyAnkh commented May 7, 2025

I’d prefer to list async-io as a direct dependency of this example rather than of Bevy itself. Although Bevy adds async-std as dev-dependency, it appears to be used only here. What do you think?

@alice-i-cecile
Copy link
Member

I'm okay with that but I had no idea that was possible. Can you make the change to demonstrate?

@VitalyAnkh
Copy link
Contributor Author

The plan is to package the async‑compute examples like the mobile example then we could specify dependencies in Cargo.toml (

), but since dev-dependencies don’t affect runtime, the current arrangement works fine.

This should be ready for merging now.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels May 9, 2025
@janhohenheim janhohenheim added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

example async_compute.rs uses the discontinued async-std
3 participants