Two issue has been added: #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. --log-folder and --tmp-folder command line arguments to get the files locations more flexible 2. "expiration_days" (non-intеger values are avalible also) in server config file's section "auth" to limit auth cookie life time. The default value is 30 days if the param is underfined. Changes to be committed: modified: src/auth/auth_base.py modified: src/auth/tornado_auth.py modified: src/main.py modified: src/model/server_conf.py
bugy
approved these changes
Jun 18, 2020
There was a problem hiding this comment.
Thanks! Looks good, just one tiny improvement suggestion
Regarding the /tmp folder, what is your take on this comment: #306 (comment)? :)
src/model/server_conf.py
Outdated
| else: | ||
| raise Exception(auth_type + ' auth is not supported') | ||
|
|
||
| authenticator.auth_expiration_days = float(auth_object.get('expiration_days')) if auth_object.get('expiration_days') is not None else 30 |
There was a problem hiding this comment.
I think you can use default value here:
auth_object.get('expiration_days', '30')
Changes to be committed: modified: src/model/server_conf.py
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: src/auth/auth_base.py
modified: src/auth/tornado_auth.py
modified: src/main.py
modified: src/model/server_conf.py