Skip to content

Update Sandbox API key procedure. (bunq/sdk_python#100) #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2018

Conversation

sandervdo
Copy link
Contributor

@sandervdo sandervdo commented Jun 11, 2018

This PR closes/fixes the following issues:

@sandervdo sandervdo requested a review from OGKevin June 11, 2018 20:24
@sandervdo sandervdo self-assigned this Jun 11, 2018
README.md Outdated
@@ -10,7 +10,8 @@ Now you can build even bigger and better apps and integrate them with your bank

Before you dive into this brand new SDK, please consider:
- Checking out our new developer’s page [https://bunq.com/en/developer](https://bunq.com/en/developer) 🙌
- Grabbing your production API key from the bunq app or asking our support for a Sandbox API key 🗝
- Grabbing your production API key from the bunq app or generate a Sandbox API key using the
[Tinker endpoint](https://together.bunq.com/topic/tinker-the-api) 🗝
Copy link
Contributor

@OGKevin OGKevin Jun 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ..API key using tinker instead of .. the tinker endpoint

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OGKevin let's keep the discussion about the phrasing in one PR; I added endpoint on purpose. There's already a lot of confusion where people think Tinker is another SDK/API, while it's just an endpoint. Hence, I made it explicit here. Still want me to change it?

@OGKevin OGKevin added this to the 0.13.5 milestone Jun 12, 2018
@sandervdo
Copy link
Contributor Author

@OGKevin and the last one, pushed.

@OGKevin OGKevin merged commit fb9a555 into develop Jun 20, 2018
@OGKevin
Copy link
Contributor

OGKevin commented Jun 20, 2018

@andrederoos

@OGKevin OGKevin deleted the update-sandbox-api-key-procedure branch June 20, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Sandbox API key procedure
2 participants