chore: Migrate Button component to logical properties #1729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
=======================================
Coverage 94.40% 94.40%
=======================================
Files 652 652
Lines 17635 17635
Branches 5800 5800
=======================================
Hits 16648 16648
Misses 919 919
Partials 68 68 ☔ View full report in Codecov by Sentry. |
DaemonCahill
requested review from
connorlanigan and
just-boris
and removed request for
a team
just-boris
reviewed
Nov 13, 2023
just-boris
reviewed
Nov 13, 2023
DaemonCahill
force-pushed
the
scottob-button-logical-properties
branch
from
a2664a4 to
5318e3e
Compare
just-boris
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a subset of the changes drafted in #1713 to ensure that the migration to logical properties across the codebase will not create unintended failures upon merging.