Skip to content

Conversation

@Leask
Copy link
Contributor

@Leask Leask commented Dec 4, 2025

To launch the demo service, node-pty and ws are required.

To launch the demo service, `node-pty` and `ws` are required.
Copilot AI review requested due to automatic review settings December 4, 2025 17:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds @lydell/node-pty and ws as dependencies to the root package.json to support running the demo service via the demo and demo:dev npm scripts, which execute demo/bin/demo.js that imports these packages for PTY and WebSocket functionality.

  • Adds @lydell/node-pty@^1.1.0 for cross-platform PTY support
  • Adds ws@^8.18.3 for WebSocket server functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"vite-plugin-dts": "^4.5.4"
"vite-plugin-dts": "^4.5.4",
"@lydell/node-pty": "^1.1.0",
"ws": "^8.18.3"
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version inconsistency: demo/package.json specifies ws@^8.18.0 while this adds ^8.18.3. Consider aligning these versions to ensure consistent behavior between the demo package and the root package's demo scripts.

Suggested change
"ws": "^8.18.3"
"ws": "^8.18.0"

Copilot uses AI. Check for mistakes.
"vite": "^4.5.0",
"vite-plugin-dts": "^4.5.4"
"vite-plugin-dts": "^4.5.4",
"@lydell/node-pty": "^1.1.0",
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These packages should be added to dependencies rather than devDependencies. The demo and demo:dev scripts (lines 47-48) run demo/bin/demo.js which imports these packages, so they need to be available in production environments, not just during development.

Suggested change
"@lydell/node-pty": "^1.1.0",
"@lydell/node-pty": "^1.1.0"
},
"dependencies": {

Copilot uses AI. Check for mistakes.
"vite": "^4.5.0",
"vite-plugin-dts": "^4.5.4"
"vite-plugin-dts": "^4.5.4",
"@lydell/node-pty": "^1.1.0",
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version inconsistency: demo/package.json specifies @lydell/node-pty@^1.0.1 while this adds ^1.1.0. Consider aligning these versions to ensure consistent behavior between the demo package and the root package's demo scripts.

Copilot uses AI. Check for mistakes.
@Leask
Copy link
Contributor Author

Leask commented Dec 4, 2025

It turns out it was already included in the demo. Sorry. Closed.

@Leask Leask closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant