-
Notifications
You must be signed in to change notification settings - Fork 42
Adding the missing package descriptions. #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To launch the demo service, `node-pty` and `ws` are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds @lydell/node-pty and ws as dependencies to the root package.json to support running the demo service via the demo and demo:dev npm scripts, which execute demo/bin/demo.js that imports these packages for PTY and WebSocket functionality.
- Adds
@lydell/node-pty@^1.1.0for cross-platform PTY support - Adds
ws@^8.18.3for WebSocket server functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "vite-plugin-dts": "^4.5.4" | ||
| "vite-plugin-dts": "^4.5.4", | ||
| "@lydell/node-pty": "^1.1.0", | ||
| "ws": "^8.18.3" |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version inconsistency: demo/package.json specifies ws@^8.18.0 while this adds ^8.18.3. Consider aligning these versions to ensure consistent behavior between the demo package and the root package's demo scripts.
| "ws": "^8.18.3" | |
| "ws": "^8.18.0" |
| "vite": "^4.5.0", | ||
| "vite-plugin-dts": "^4.5.4" | ||
| "vite-plugin-dts": "^4.5.4", | ||
| "@lydell/node-pty": "^1.1.0", |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These packages should be added to dependencies rather than devDependencies. The demo and demo:dev scripts (lines 47-48) run demo/bin/demo.js which imports these packages, so they need to be available in production environments, not just during development.
| "@lydell/node-pty": "^1.1.0", | |
| "@lydell/node-pty": "^1.1.0" | |
| }, | |
| "dependencies": { |
| "vite": "^4.5.0", | ||
| "vite-plugin-dts": "^4.5.4" | ||
| "vite-plugin-dts": "^4.5.4", | ||
| "@lydell/node-pty": "^1.1.0", |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version inconsistency: demo/package.json specifies @lydell/node-pty@^1.0.1 while this adds ^1.1.0. Consider aligning these versions to ensure consistent behavior between the demo package and the root package's demo scripts.
|
It turns out it was already included in the demo. Sorry. Closed. |
To launch the demo service,
node-ptyandwsare required.