Skip to content

Adding the missing package descriptions. #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Leask wants to merge 1 commit into from
Closed

Adding the missing package descriptions. #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@
"prettier": "^3.6.2",
"typescript": "^5.9.3",
"vite": "^4.5.0",
"vite-plugin-dts": "^4.5.4"
"vite-plugin-dts": "^4.5.4",
"@lydell/node-pty": "^1.1.0",
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These packages should be added to dependencies rather than devDependencies. The demo and demo:dev scripts (lines 47-48) run demo/bin/demo.js which imports these packages, so they need to be available in production environments, not just during development.

Suggested change
"@lydell/node-pty": "^1.1.0",
"@lydell/node-pty": "^1.1.0"
},
"dependencies": {

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version inconsistency: demo/package.json specifies @lydell/node-pty@^1.0.1 while this adds ^1.1.0. Consider aligning these versions to ensure consistent behavior between the demo package and the root package's demo scripts.

Copilot uses AI. Check for mistakes.
"ws": "^8.18.3"
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version inconsistency: demo/package.json specifies ws@^8.18.0 while this adds ^8.18.3. Consider aligning these versions to ensure consistent behavior between the demo package and the root package's demo scripts.

Suggested change
"ws": "^8.18.3"
"ws": "^8.18.0"

Copilot uses AI. Check for mistakes.
}
}