Ignore MaxRequestBodySize for upgraded requests #13477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
ask-mode
BrennanConroy
requested review from
analogrelay,
halter73,
jkotalik and
Tratcher
as code owners
Tratcher
approved these changes
Aug 27, 2019
|
Unfortunately some test discovery stuff isn't working for the tests. I verified the fix locally and verified that tests will hit this when we fix the test discovery. |
jkotalik
approved these changes
Aug 27, 2019
|
This is approved by tactics. |
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ask mode template
Description
Customer reported issue in #13470.
When using WebSockets and IIS the client will be terminated after sending 30MB of data (by default) over the lifetime of the connection.
Customer Impact
Customers using Blazor or SignalR will have clients abruptly terminated if they stay connected for a long time, or are active and send ~30MB of data.
Regression?
Yes. Caused by #9475 when we added the MaxRequestBodySize feature to IIS in-proc.
Risk
Low.