-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Implement MaxRequestBodySize feature for IIS inprocess #9475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/MaxRequestBodySizeTests.cs
Show resolved
Hide resolved
Moving this out of preview 5. We are starting to limit preview 5 work to essential stuff only. |
I'm going to block myself on merging this until I figure out why a set of IIS tests aren't running on PRs. |
Re-enabled some IIS tests, this should now report success/failures correctly now. |
ee61480
to
e59736e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wonder if we can integrate closer with maxAllowedContentLength, or even override it? Let's talk offline.
94eefa3
to
56f0de6
Compare
This now adds support for reading the IIS content length limit and logs a warning per request/in the constructor for the Server. |
src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/managedexports.cpp
Outdated
Show resolved
Hide resolved
src/Servers/IIS/AspNetCoreModuleV2/InProcessRequestHandler/InProcessOptions.cpp
Outdated
Show resolved
Hide resolved
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. I've created/commented on the following issue(s) |
We just upgraded to preview-6 and suddenly our web.config setting (maxAllowedContentLength) seems to not be working anymore. We run on IIS in-process. Here is the config: https://github.com/Dynatrace/superdump/blob/master/src/SuperDumpService/web.config Anything wrong with the config at first glance? Should we file an issue for this? @jkotalik |
What is the error? |
the setting from web.config is not respected anymore, so it uses a much lower default. |
If you're seeing the setting be ignored, definitely file a new bug and provide a runnable sample that reproduces the problem. We can always close it if it turns out there isn't a problem (though if the behavior is confusing to you, that's a problem ;)). We don't track merged PRs like this so it's likely this will get lost if we stop checking our GitHub notifications ;). Also, include any logs from the app since it looks like we should be logging a warning if there's a conflict between these options. @jkotalik From a very cursory look at the code, I wonder if the fact that we set a default size limit in the managed code is conflicting here. Perhaps the default (if the setting isn't set) should be to just use whatever the web.config value is (if one is present)? |
Fixes #8293.
I'm okay if this slips to preview6. I'll leave comments in the diff.