Skip to content

Update release for 0.9 #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jan 8, 2019
Merged

Update release for 0.9 #2067

merged 26 commits into from
Jan 8, 2019

Conversation

shauheen
Copy link
Contributor

@shauheen shauheen commented Jan 8, 2019

This updates the release branch for 0.9

abgoswam and others added 25 commits January 2, 2019 19:54
* attempt to separate out TextLoaderStatic

* fix failing tests (ReturnTypeIsSchemaShapeChained)

* moving TextLoaderStatic to the Microsoft.ML.StaticPipe assembly

* Add MLNetStaticPipeReference to get Analyzer Tests happy

* Moving remaining static extensions to the microsoft.ML.StaticPipe assembly

* fix access modifier instead of adding BestFriend attribute

* Fix TextLoader bug

* fix build break (caused by bad merge with master in previous commit)

* review comment - maintain consistency, removing license text from sample files

* review comment - update newly added tests
1. Remove ISchema interface
2. Rename CompositeSchema to ZipBinding
* Update Iris tests to use new API

* review comments

* review comments -2 . made couple of classes private

* removed dummy initialization, and using properties instead
* API changes for GPU support

* update to test package on nuget.org

* Addressed PR comments

* Addressed PR comments

* Point to nuget on myget.org

* restore directory.build.props
* update PredictClusters test;  delete a couple of skipped tests

* delete couple of additional helper files (which were being used for skipped tests)

* remove Legacy references from Microsoft.ML.TestFramework.csproj and EnvironmentExtensions.cs

* fix EntryPointCatalog test
* Remove ColumnType.IsBool

* Remove ColumnType.IsPrimitive

* Remove ColumnType.IsNumber

* Remove ColumnType.IsText

* Move ColumnType.IsStandardScalar to an extension method.
* Added more documentation and extra CPU path test

* minor change to kick off build
* Remove Legacy dependency from Microsoft.ML.Benchmarks

* Use model.Transform for batch prediction benchmarks

* Removing #pragma warning disable

* Using one mlContext for both training and prediction
…2015)

* Remove legacy API test that already have coverage and refactor code.

* PR feedback.
* remove legacy from textloader need to test with build fix

* fixed test

* review comments

* updated exception test and answered review comments

* exception

* fixed typo
* Prototype of new ONNX converter and an end-to-end test

* Reuse existing code to do conversion and polish a test

* Test Kmeans as well

* 1. Introduce ONNX conversion as an extention to MLContext
2. Address minor comments

Remove two best friends

* Add test comparison

* Address comments

* Propose another domain name

* Add missing header

* One more test for one-hot encoding's conversion

* Add one more test

* Add logistic regression test

* Add LightGBM test

* Test NaN replacement and fix build for core30 and x86

* Add one more test

* Update Kmeans file due to change of initialization

* Add a test for onnx conversion cmd

* Add word embedding test

* Remove old tests

* increase tol

* Drop version in saved baseline file

* make c30 happy

* Make c30 happier

* c30 needs even more
…2036)

* Expose internal APIs to components in internal repo

* Address code review comments
@shauheen shauheen requested a review from abgoswam January 8, 2019 06:15
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloned your repo, built the packages locally and ran a simple SDCA example using Microsoft.ML nuget and it ran without any issues.

@eerhardt
Copy link
Member

eerhardt commented Jan 8, 2019

Just an FYI - since this .csproj is not targeting a NuGet package, we are no longer shipping the "static API".

/cc @TomFinley


Refers to: src/Microsoft.ML.StaticPipe/Microsoft.ML.StaticPipe.csproj:3 in 7e28d21. [](commit_id = 7e28d21, deletion_comment = False)

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eerhardt
Copy link
Member

eerhardt commented Jan 8, 2019

REMINDER: Don't squash this.

@TomFinley
Copy link
Contributor

TomFinley commented Jan 8, 2019

Just an FYI - since this .csproj is not targeting a NuGet package, we are no longer shipping the "static API".

Whoops... we should ultimately put them in a new nuget, but unshipping them altogether is not a good story. I have a small issue #2072 to address this right now, so that the assemblies are associated with their old nugets, though we should have the aim of having the static API in a separate "unstable" nuget, per other discussions.

Or perhaps just making a new nuget! That also works. 😛 Per #1076.

@shauheen shauheen merged commit 941d9fc into dotnet:release/preview Jan 8, 2019
@shauheen shauheen deleted the release/v09rc2 branch January 9, 2019 20:10
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.