Correct inferring tensor shape for Tensorflow Transform #4509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashbhandare I know this is in Draft but please don't forget to add functionality to pass in shape from text loader just the same way we support with IEnumerable otherwise the fix is incomplete. |
|
As the issue this PR addresses is already closed, I am closing this PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4364 partially.
The above issue brought into attention that there was a wrong assumption while inferring input tensor shape in TensorflowTransform. It was assumed that for a input node of a graph with unknown dimensions, all the dimensions would be the same, even though that is not true in most cases. For example, the most common tensor shape format for dealing with Image- based models is (batch_size, height, width, channels).
This change replaces this wrong check with more comprehensive method of inferring the input tensor shape.
More tests might need to be added for code coverage.