Add two-variable scenario in Tensor shape inference for TensorflowTransform #5257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5257 +/- ##
==========================================
+ Coverage 73.49% 73.75% +0.25%
==========================================
Files 1014 1022 +8
Lines 188680 190229 +1549
Branches 20330 20464 +134
==========================================
+ Hits 138677 140303 +1626
+ Misses 44493 44413 -80
- Partials 5510 5513 +3
|
wangyems
changed the title
harishsk
reviewed
Jul 1, 2020
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Outdated
Show resolved
Hide resolved
harishsk
reviewed
Jul 1, 2020
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Outdated
Show resolved
Hide resolved
harishsk
reviewed
Jul 1, 2020
test/Microsoft.ML.Tests/ScenariosWithDirectInstantiation/TensorflowTests.cs
Outdated
Show resolved
Hide resolved
harishsk
reviewed
Jul 1, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix 4364
There are a couple of image related scenarios that tensor shape inferencing should handle (tensor usually has shape [W,H,C] or [N,W,H,C] and usually W = H), the first three are covered by current implementation. This PR added the fourth one.
1, [?, ?, C]
2, [?, W, H, C]
3, [N, ?, ?, C]
4, [?, ?, ?, C] (added in this PR)
There was another PR that attempted to resolve this in the past and it considered scenarios like [?, W, ?, C] or [?, ?, H, C] but I am not sure(and never seen) these could be any deep learning scenarios. We can discuss this since I could be wrong and I will add those scenarios if necessary.