Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally I converted most owned native objects to
std::unique_ptr
andstd::shared_ptr
. This pull request represents a relatively easy-to-review subset of the changes with minimal overall fan-out in the code.std::unique_ptr
for objects inLdaEngine
(submitted separately as Use std::unique_ptr for objects in LdaEngine #4547)std::unique_ptr
forsamplers_
andlikelihood_in_iter_