This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Fixes issue with password saving when using Bitwarden #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2023
afterxleep
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 4, 2023
Task/Issue URL: https://app.asana.com/0/1177771139624306/1205398889304566/f BSK PR: duckduckgo/BrowserServicesKit#486 Description: Fixes an issue that causes passwords to be saved to local vault when Bitwarden is enabled.
afterxleep
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 4, 2023
Task/Issue URL: https://app.asana.com/0/1177771139624306/1205398889304566/f BSK PR: duckduckgo/BrowserServicesKit#486 Description: Fixes an issue that causes passwords to be saved to local vault when Bitwarden is enabled. -- This was released via a cold-fix. This just updates develop to point to the right BSK version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1177771139624306/1205398889304566/f
iOS PR: duckduckgo/iOS#1969
macOS PR: duckduckgo/macos-browser#1584
What kind of version bump will this require?: Minor
Description:
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template