Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Fixes issue with password saving when using Bitwarden #486

Closed
wants to merge 2 commits into from
Closed

Fixes issue with password saving when using Bitwarden #486

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e8ccb9
Fixes issue with password saving when using Bitwarden
afterxleep Sep 1, 2023
e928003
Make linter happy
afterxleep Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,10 +252,8 @@ extension SecureVaultManager: AutofillSecureVaultDelegate {
autosaveAccountCreatedInSession = false
}
}

try storeOrUpdateAutogeneratedCredentials(domain: domain, autofillData: autofilldata)

// Update/Prompt in 3rd party password manager
// Update/Prompt in 3rd party password manager (if enabled)
if let passwordManager = passwordManager, passwordManager.isEnabled {
if !shouldSilentlySave {
let dataToPrompt = try existingEntries(for: domain, autofillData: autofilldata)
Expand All @@ -264,6 +262,9 @@ extension SecureVaultManager: AutofillSecureVaultDelegate {
autosaveAccountCreatedInSession = false
}
return
} else {
// Store or update silently (if required)
try storeOrUpdateAutogeneratedCredentials(domain: domain, autofillData: autofilldata)
}

// Prompt or notify on form submissions and clean any partial accounts for this instance (tab)
Expand Down