This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Update BSK reference to include the disable rekeying flag #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 5, 2023
Task/Issue URL: https://app.asana.com/0/1199333091098016/1206100276423377/f iOS PR: duckduckgo/iOS#2219 macOS PR: duckduckgo/macos-browser#1922 What kind of version bump will this require?: Major Optional: Tech Design URL: CC: Description: This PR adds a setting to disable rekeying.
samsymons
added a commit
that referenced
this pull request
Dec 7, 2023
* main: Updates BSK (#2239) Add Geoswitching pixels (#2235) Fix spacing between buttons (#2237) Update all references to develop branch with main (#2231) Update TRK (#2200) Breakage report improvements (#2197) Update BSK reference to include the disable rekeying flag (#2219) Final NetP ship review feedback (#2221) Improve handling lists in Sync (#2192) remove address bar position pixels (#2220)
samsymons
added a commit
that referenced
this pull request
Dec 7, 2023
# By Graeme Arthur (3) and others # Via GitHub * main: Updates BSK (#2239) Add Geoswitching pixels (#2235) Fix spacing between buttons (#2237) Update all references to develop branch with main (#2231) Update TRK (#2200) Breakage report improvements (#2197) Update BSK reference to include the disable rekeying flag (#2219) Final NetP ship review feedback (#2221) Improve handling lists in Sync (#2192) remove address bar position pixels (#2220) # Conflicts: # DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo.xcscheme
samsymons
added a commit
that referenced
this pull request
Dec 11, 2023
* main: Enable NetP in production builds (#2232) Report macOS NetP connection attempts & tunnel failures (#2234) Always use black and white colors for the QR code (#2248) Update BSK with autofill 10.0.1 (#2245) Ensure that LinkPresentation framework is called on main thread (#2241) expose window.print handler to page world (#2243) Updates BSK (#2239) Add Geoswitching pixels (#2235) Fix spacing between buttons (#2237) Update all references to develop branch with main (#2231) Update TRK (#2200) Breakage report improvements (#2197) Update BSK reference to include the disable rekeying flag (#2219) Final NetP ship review feedback (#2221) Improve handling lists in Sync (#2192) remove address bar position pixels (#2220) Address Bar Spoofing Tests + Remediation (#2181) Update Sync e2e tests to fit the new UI (#2215) NetP waitlist final touches (#2209)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206100276423377/f
Tech Design URL:
CC:
Description:
This PR updates BSK to include a NetP settings change. The change isn't used here in any way.
Steps to test this PR:
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template