Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@brindy
Copy link
Contributor

@brindy brindy commented Dec 5, 2023

Task/Issue URL: https://app.asana.com/0/414235014887631/1205603672529838/f
Tech Design URL:
CC:

Description:

Remove pixels for address bar position.

Steps to test this PR:

  1. Launch the app and switch address bar position
  2. Ensure no pixel sent when position changes

@brindy brindy requested review from a team and mallexxx and removed request for a team and mallexxx December 5, 2023 13:31
@Bunn Bunn self-requested a review December 5, 2023 13:34
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit 000aa58 into develop Dec 5, 2023
@brindy brindy deleted the brindy/remove-bottom-bar-pixels branch December 5, 2023 13:45
samsymons added a commit that referenced this pull request Dec 5, 2023
# By Christopher Brind (1) and Dominik Kapusta (1)
# Via GitHub
* develop:
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Dec 7, 2023
* main:
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)
samsymons added a commit that referenced this pull request Dec 7, 2023
# By Graeme Arthur (3) and others
# Via GitHub
* main:
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)

# Conflicts:
#	DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGo.xcscheme
samsymons added a commit that referenced this pull request Dec 11, 2023
* main:
  Enable NetP in production builds (#2232)
  Report macOS NetP connection attempts & tunnel failures (#2234)
  Always use black and white colors for the QR code (#2248)
  Update BSK with autofill 10.0.1 (#2245)
  Ensure that LinkPresentation framework is called on main thread (#2241)
  expose window.print handler to page world (#2243)
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  Update BSK reference to include the disable rekeying flag (#2219)
  Final NetP ship review feedback (#2221)
  Improve handling lists in Sync (#2192)
  remove address bar position pixels (#2220)
  Address Bar Spoofing Tests + Remediation (#2181)
  Update Sync e2e tests to fit the new UI (#2215)
  NetP waitlist final touches (#2209)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants