Skip to content

[CI] VectorScorerFactoryTests testRandomScorerMax failing #126797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elasticsearchmachine opened this issue Apr 14, 2025 · 5 comments · Fixed by #126849
Closed

[CI] VectorScorerFactoryTests testRandomScorerMax failing #126797

elasticsearchmachine opened this issue Apr 14, 2025 · 5 comments · Fixed by #126849
Assignees
@thecoop
Labels
low-risk An open issue or test failure that is a low risk to future releases :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI

Comments

@elasticsearchmachine
Copy link
Collaborator

Build Scans:

Reproduction Line:

./gradlew ":libs:simdvec:test" --tests "org.elasticsearch.simdvec.VectorScorerFactoryTests.testRandomScorerMax" -Dtests.seed=7FDA25580A95E52C -Dtests.locale=en-KN -Dtests.timezone=Africa/Bissau -Druntime.java=24

Applicable branches:
main

Reproduces locally?:
N/A

Failure History:
See dashboard

Failure Message:

java.lang.AssertionError: expected:<743.881> but was:<743.88086>

Issue Reasons:

  • [main] 2 failures in test testRandomScorerMax (1.1% fail rate in 189 executions)

Note:
This issue was created using new test triage automation. Please report issues or feedback to es-delivery.
@elasticsearchmachine elasticsearchmachine added :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels Apr 14, 2025
@elasticsearchmachine
Copy link
Collaborator Author

This has been muted on branch main

Mute Reasons:

  • [main] 2 failures in test testRandomScorerMax (1.1% fail rate in 189 executions)

Build Scans:

elasticsearchmachine added a commit that referenced this issue Apr 14, 2025
@elasticsearchmachine
Mute org.elasticsearch.simdvec.VectorScorerFactoryTests testRandomSco…
ff42cb6 
…rerMax #126797
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 14, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-search (Team:Search)

@thecoop
Copy link
Member

thecoop commented Apr 15, 2025

I suspect this and #126847 are failing on lucene 10.2 because of the new Panama implementations in lucene, that is changing the floating-point calculations slightly. We need to do a scaled delta here, similar to #124722

@thecoop thecoop mentioned this issue Apr 15, 2025
Merged
@thecoop thecoop added :Search Relevance/Vectors Vector search low-risk An open issue or test failure that is a low risk to future releases and removed :Search/Search Search-related issues that do not fall into other categories needs:risk Requires assignment of a risk label (low, medium, blocker) labels Apr 15, 2025
@elasticsearchmachine elasticsearchmachine added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Apr 15, 2025
@elasticsearchmachine
Copy link
Collaborator Author

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@benwtrent
Copy link
Member

@thecoop

because of the new Panama implementations in lucene

Yeah, for sure since now scalar quantization utilizes panama optimizations as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thecoop thecoop

Labels
low-risk An open issue or test failure that is a low risk to future releases :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak the delta used for vector scorer tests thecoop/elasticsearch
3 participants
@thecoop @benwtrent @elasticsearchmachine